Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need tree-sequence-level metadata #725

Closed
molpopgen opened this issue May 29, 2021 · 0 comments · Fixed by #742
Closed

Need tree-sequence-level metadata #725

molpopgen opened this issue May 29, 2021 · 0 comments · Fixed by #742
Milestone
0.15.0

Comments

@molpopgen
Copy link
Owner

If a user wants to put something important about an output somewhere, there's not a good place for it.
We should add ts-level metadata to the schema and have a "user stuff" field.
@molpopgen molpopgen added this to the 0.15.0 milestone May 31, 2021
@molpopgen molpopgen linked a pull request Jun 2, 2021 that will close this issue
Refine tskit metadata #742
Merged
molpopgen added a commit that referenced this issue Jun 2, 2021
@molpopgen
DiploidMetadata.[alive|preserved|first_generation] are now converted …
9dfc09f 
…to the intended

bool.

Add link to vignette from DiploidPopulation.dump_tables_to_tskit docs.

Add passing ModelParams to DiploidPopulation.dump_tables_to_tskit in
tests.

Remove unused docstring from _dump_tables_to_tskit.

Breaking change: all non-self arguments to
DiploidPopulation.dump_tables_to_tskit are now kw-only.

Add top-level tree-sequence/table collection metadata. Closes #725

Allow user-specified population table metadata. Closes #740
molpopgen added a commit that referenced this issue Jun 2, 2021
@molpopgen
Refine tskit metadata (#742)
910465f 
* DiploidMetadata.[alive|preserved|first_generation] are now converted to the intended
bool.

Add link to vignette from DiploidPopulation.dump_tables_to_tskit docs.

Add passing ModelParams to DiploidPopulation.dump_tables_to_tskit in
tests.

Remove unused docstring from _dump_tables_to_tskit.

Breaking change: all non-self arguments to
DiploidPopulation.dump_tables_to_tskit are now kw-only.

Add top-level tree-sequence/table collection metadata. Closes #725

Allow user-specified population table metadata. Closes #740

* Update docstring for DiploidPopulation.dump_tables_to_tskit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

Refine tskit metadata molpopgen/fwdpy11
1 participant
@molpopgen