Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deme names to tskit metadata #740

Closed
molpopgen opened this issue Jun 1, 2021 · 1 comment
Closed

Add deme names to tskit metadata #740

molpopgen opened this issue Jun 1, 2021 · 1 comment
Milestone
0.15.0

Comments

@molpopgen
Copy link
Owner

When using, say, a demes graph, populations may have meaningful names. These should be written to the population table metadata, which currently assigns default names.
@molpopgen
Copy link
Owner Author

There are multiple ways to think about getting this:

  1. From a demes.Graph directly,
  2. From a demographic model object
  3. Require a user-generated dict with the "right stuff" inside.

Option 3 is definitely the easiest.

molpopgen added a commit that referenced this issue Jun 2, 2021
@molpopgen
DiploidMetadata.[alive|preserved|first_generation] are now converted …
9dfc09f 
…to the intended

bool.

Add link to vignette from DiploidPopulation.dump_tables_to_tskit docs.

Add passing ModelParams to DiploidPopulation.dump_tables_to_tskit in
tests.

Remove unused docstring from _dump_tables_to_tskit.

Breaking change: all non-self arguments to
DiploidPopulation.dump_tables_to_tskit are now kw-only.

Add top-level tree-sequence/table collection metadata. Closes #725

Allow user-specified population table metadata. Closes #740
@molpopgen molpopgen added this to the 0.15.0 milestone Jun 2, 2021
molpopgen added a commit that referenced this issue Jun 2, 2021
@molpopgen
Refine tskit metadata (#742)
910465f 
* DiploidMetadata.[alive|preserved|first_generation] are now converted to the intended
bool.

Add link to vignette from DiploidPopulation.dump_tables_to_tskit docs.

Add passing ModelParams to DiploidPopulation.dump_tables_to_tskit in
tests.

Remove unused docstring from _dump_tables_to_tskit.

Breaking change: all non-self arguments to
DiploidPopulation.dump_tables_to_tskit are now kw-only.

Add top-level tree-sequence/table collection metadata. Closes #725

Allow user-specified population table metadata. Closes #740

* Update docstring for DiploidPopulation.dump_tables_to_tskit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
1 participant
@molpopgen