Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DST change in Egypt is not taken into account (GMT+2 => GMT+3) #1051

Closed
robinfla opened this issue Mar 30, 2023 · 0 comments
Closed

DST change in Egypt is not taken into account (GMT+2 => GMT+3) #1051

robinfla opened this issue Mar 30, 2023 · 0 comments

Comments

@robinfla
Copy link

robinfla commented Mar 30, 2023

Moment-timezone version which you use:

Version: 0.5.42

Note: many issues are resolved if you just upgrade to the latest version

Issue description:

Egypt has announced that they're bringing back DST starting from the last Friday of April this year: https://egyptianstreets.com/2023/03/01/egypt-brings-daylight-saving-time-back/

We've noticed that the moment package does not return the correct hour for dates after April 28th:
For instance:
moment('2023-05-24 18:20:00+00').tz('Africa/Cairo') will return 2023-05-24 20:20:00 instead of 2023-05-24 21:20:00

EDIT: I just saw that this was fixed recently: #1047
I'm digging a bit more to understand why it doesn't work for me and will close this issue if irrelevant, sorry for the noise.

EDIT 2: Turns out it was our frontend that hadn't updated moment to 0.5.42....our bad. Closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant