-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify jspm dependencies for moment #234
Conversation
Specify jspm dependencies for moment
For me this change increased the minified source of my project by almost 200 kB. It seems that for some reason JSPM is now pulling in a long chain of Node.js shim libraries (base64, zlib, buffer, stream, process, …) and Browserify modules, which clearly aren't necessary for moment to work. Any ideas on how to fix this? |
That makes no sense... this change just makes moment-timezone depend on moment. moment doesn't have any other dependencies... |
@lookfirst Try the following steps in an empty directory and you'll see a big difference between 0.4.0 and 0.4.1: $ npm init # just use all the defaults
$ npm install jspm --save-dev
$ jspm init # just use all the defaults
$ echo "import moment from 'moment-timezone'; console.log(moment().format());" > index.js
# First, let's try v0.4.0
$ jspm install npm:moment-timezone@0.4.0
$ jspm bundle-sfx index index.bundled.js
$ ls -la
# Now, let's try v0.4.1
$ jspm install npm:moment-timezone@0.4.1
$ jspm bundle-sfx index index.bundled.js
$ ls -la When following the above steps, I see the bundle size going from 105 kB (0.4.0) to 255 kB (0.4.1). |
@blixt I'd file a bug with jspm... that just seems wrong... =( |
@lookfirst Ok I'll file an issue. By the way, why does the dependency specify |
@lookfirst I've been debugging this and I don't think it's jspm's fault. The main reason for the bump in the package size actually seems to be because of #237 which includes the |
@blixt meh. =( well at least it wasn't my change. =) |
No description provided.