deprecate pre-2.0 add/subtract #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing Belarusian language
Convert double quotes to single quotes in moment.js
|
Looks like I'll need to rebase. I'll do that after I get some feedback. |
| @@ -487,7 +497,23 @@ | |||
| return res; | |||
| } | |||
|
|
|||
| // helper function for _.addTime and _.subtractTime | |||
| //todo: remove 'name' arg after deprecation is removed | |||
|
Pretty good, I would have done the same. Great job with fixing all the internal uses and renaming the tests. Reverse reverse args for the win :) You can merge after the rebase. |
Change duration.toIsoString to duration.toISOString @changelog @section deprecation @description rename duration.toIsoString to duration.toISOString
Simplify readme
icambron
added a commit
that referenced
this pull request
Jul 14, 2014
deprecate pre-2.0 add/subtract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1729: