Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large repack does not load on Firefox/IE #54

Closed
Sharingisnotillegal opened this issue Sep 14, 2021 · 3 comments
Closed

Large repack does not load on Firefox/IE #54

Sharingisnotillegal opened this issue Sep 14, 2021 · 3 comments

Comments

@Sharingisnotillegal
Copy link

Sharingisnotillegal commented Sep 14, 2021

Hi,

An issue i've been able to reproduce on multiple computer/devices is:
Get a large repack.
Try to load site on firefox, when it looks like it is done completing it will exit with:
"TypeError: can't access property "replace", e is null"
Currently hosting it on https://cur dot ie/ if it is of any help.
repack is located on
https://cur dot ie/own.zip

Example of working pack :
https://cur dot ie/own2.zip

File path browsing is enabled, so you can go to /lib etc if you think something is off.

Hosted on IIS8
Not working on:
Firefox 93.0b4 (64-bit)
Firefox 92.0b9 (64-bit)

I suspect the following not loading is also related, but not sure.
Firefox (Mobile) 92.1.1 Build#352471817 92.0-20210903235534 (TypeError: e is null)
Internet explorer 11
error: Initialising... 'Promise' is undefined

Working fine on:
Edge Version 93.0.961.47 (Official build) (64-bit)
Chrome Version 93.0.4577.82 (Official Build) (64-bit)
Chrome Mobile 93.0.4577.62

@mon
Copy link
Owner

mon commented Sep 14, 2021

IE is absolutely cooked and I don't expect it to work - it's probably missing large chunks of the canvas api to even render properly.

The other browsers I'll see if I can take a look on the weekend. Might be a problem with the zip loading library, might be something else.

@mon
Copy link
Owner

mon commented Sep 17, 2021

I took a quick look - songs.xml is malformed. The last song is missing the closing song tag. This error is printed in the console.

I'll update the zip library later anyway, it seems to have received many speed boosts since I included it.

@mon
Copy link
Owner

mon commented Oct 2, 2021

Closing for now since I've just updated zip.js (it's like 2x faster to load now which is pretty cool) and the problem seems to be a broken respack instead of 0x40 being broken.

Feel free to re-open the issue if it's not working after you fix the XML!

@mon mon closed this as completed Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants