Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Implement FaceID to unlock the app on open #992

Open
2 tasks done
tmolitor-stud-tu opened this issue Jan 15, 2024 · 11 comments
Open
2 tasks done

[Feature]: Implement FaceID to unlock the app on open #992

tmolitor-stud-tu opened this issue Jan 15, 2024 · 11 comments
Labels
🎃 GSOC Teaser GSOC teaser task

Comments

@tmolitor-stud-tu
Copy link
Member

Precondition

  • I understood that this template is only for feature requests and not for bug reports

Cross-checked related issues?

Describe your feature

Implement FaceID unlocking when opening the app.

This should be optional and configurable via a new settings page.

@tmolitor-stud-tu tmolitor-stud-tu added the 🎃 GSOC Teaser GSOC teaser task label Jan 15, 2024
@SjxSubham
Copy link

SjxSubham commented Feb 23, 2024

I'm interested to work on this,
I want to know more about this...
can i get assigned?

@tmolitor-stud-tu
Copy link
Member Author

Sure, thanks!

@tmolitor-stud-tu
Copy link
Member Author

Before you start to fully implement it: please tell us where you are planning to change the UX conceptionally and what code parts you presumably want to change for that.

@SjxSubham
Copy link

SjxSubham commented Feb 26, 2024

Hlw @tmolitor-stud-tu , after exploring codebase.

I will include a key NSFaceIDUsageDescription key in Info.plist file
and I will make change in the <!--Settings--> part of Main.storyboard file
from that part i think it's needed to be changed, I think from that portion it should be good for begining the change...

Pls, let me know if i'm going at right path or not, If i'm wrong then pls suggest....
:-)

@tmolitor-stud-tu
Copy link
Member Author

  1. Yes, that usage key is correct
  2. What do you plan to change in the storyboard?
  3. How do you plan to block the UI before you unlock the app using FaceID?

Overall that path seems to be right :)
You can contact me via xmpp, too (faster responses etc.): xmpp:thilo.molitor@juforum.de

@tmolitor-stud-tu
Copy link
Member Author

For all interested in participating in GSOC, I wrote a quick "how to" checklist over at our wiki: https://github.com/monal-im/Monal/wiki/GSOC-2024-Guidline

@SjxSubham
Copy link

SjxSubham commented Mar 2, 2024

Sure, I will definitely Apply for it...
I was not figuring out how to reach u..., but after read that documentation I think I will be able to contact with u for faster response...
:-)

It will be my pleasure if I can contribute and got selected in Gsoc ❤️

Can i get ur email too??
for alternative contact

@tmolitor-stud-tu
Copy link
Member Author

Apparently I overlooked your email request, here it is: info@monal-im.org

@tmolitor-stud-tu
Copy link
Member Author

Nothing happened in 2 weeks, I'll remove the assignment to make it possible for other gsoc applicant to complete this task.

@SjxSubham
Copy link

SjxSubham commented Mar 17, 2024

Already on the way to raise the PR , just stucked into improving the swift file...
So it takes much time, sir
besides our college exams are going :-)

@tmolitor-stud-tu
Copy link
Member Author

@SjxSubham okay, I reassigned you again. I'm looking forward to your pr :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎃 GSOC Teaser GSOC teaser task
Projects
None yet
Development

No branches or pull requests

2 participants