Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: When the contact has no published OMEMO keys, Monal sends a known unusable message #1017

Closed
5 tasks done
linkmauve opened this issue Mar 14, 2024 · 4 comments
Closed
5 tasks done

[Bug]: When the contact has no published OMEMO keys, Monal sends a known unusable message #1017

linkmauve opened this issue Mar 14, 2024 · 4 comments

Comments

@linkmauve
Copy link
Contributor

What Monal Release channel are you using?

AppStore

iOS system version

No response

iOS Monal version

No response

macOS system version

No response

macOS Monal version

No response

Used XMPP server (domain)

jabber.fr

Which XMPP-Server software are you using?

Prosody

XMPP Server Software Version

trunk changeset 95d8875c90dc

How many accounts are you using in Monal?

1

What happened?

The person using Monal tried to send me that stanza, probably because she forgot to disable OMEMO manually, but Monal shouldn’t let her send it anyway since it can’t be actioned on the other side:

<message type="chat" xml:lang="en" to="*me*@*my-server*" id="A7F8FB0C-33C4-4BB6-9B9E-1DA499C30470" from="*her*@*her-server*/Monal-iOS.*id*">
    <origin-id xmlns="urn:xmpp:sid:0" id="A7F8FB0C-33C4-4BB6-9B9E-1DA499C30470" />
    <body>[This message is OMEMO encrypted]</body>
    <encryption xmlns="urn:xmpp:eme:0" name="OMEMO" namespace="eu.siacs.conversations.axolotl" />
    <request xmlns="urn:xmpp:receipts" />
    <markable xmlns="urn:xmpp:chat-markers:0" />
    <store xmlns="urn:xmpp:hints" />
</message>

Anything else?

No response

FAQ

Considerations for XMPP users

Related Issues

XEP-Check

  • I have checked that at least XEP-198, XEP-0280, XEP-0352, XEP-0357, XEP-0313 and XEP-0163 are activated on my server and shown as 'green' under Settings --> Account--> (i) in advanced settings

Notifications-Menu

  • I have checked that all checkmarks are present under Settings --> Notifications
@matthewrfennell
Copy link
Member

I'm not associated with Monal, just interested in this issue. I was able to replicate this.

  • Monal Stable 6.2.0 (895) on jabber.fr
  • Profanity (no OMEMO keys configured) on another Prosody server

Every time I opened the chat with the profantiy user, it showed this alert:

116B1D8C-8C01-415D-AB2E-BBD59560FB7F_125f9fb47f87939b4e33dec020d082a848384ed2

  • If I chose "Ignore" I got the same as you.
  • If I chose "Disable Encryption" I could send unencrypted messages fine.
  • If I tried to re-enable encryption, it wouldn't let me:

A2C959AA-8659-4891-898C-C7BF7B77AC99_7dd976daedfdfe5cf0d527771efbf4854d33b66a

Is it an option to remove the "Ignore" button from the first popup, and disable OMEMO entirely until the keys are properly configured?

I had a look at Conversations, Gajim and Siskin and they all (in various ways) prevent you entirely from sending OMEMO-encrypted messages in this scenario.

I'm open to working on this too if that helps, though I'd need approval from my job first.

@FriedrichAltheide
Copy link
Contributor

Is it an option to remove the "Ignore" button from the first popup, and disable OMEMO entirely until the keys are properly configured?

No. Instead the error message could be improved. Something like

  • Monal was unable to lookup the encryption keys of
  • Please check if you and added each other into your contact lists
  • Note, the contact may not support encrypted chats using OMEMO. If that is the case you can only contact using unencrypted messages

But that would be a wall of text...

I had a look at Conversations, Gajim and Siskin and they all (in various ways) prevent you entirely from sending OMEMO-encrypted messages in this scenario.

When rewriting the chat UI this could/should be improved.

@gunwixor
Copy link

gunwixor commented Apr 27, 2024 •
edited
Loading

I am unable to add new contacts via Monal. Same error about the keys. None of my contacts use xmmp. I am using JMP.chat

I add contacts via Dino. Sent messages from Dino appear in Monal but with an error

Stable 6.2.0

@tmolitor-stud-tu
Copy link
Member

tmolitor-stud-tu commented Apr 28, 2024 •
edited
Loading

@lowviz You are unable to add contacts?
This issue is about a warning message related to encryption that can be ignored (and prevents you from sending messages if you ignore it).

--> If the warning message pops up, just don't select ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tmolitor-stud-tu @linkmauve @FriedrichAltheide @gunwixor @matthewrfennell