Monal reuses stanza ids which causes id clashes

[tmolitor-stud-tu]

I just stumbled upon this log trace in prosody, showing that Monal doesn't use different ids for its stanzas when they are sent during the same second.

Oct 06 21:43:07 c2s9db7560      debug   Received[c2s]: <iq id='monal89383' type='set'>
Oct 06 21:43:07 c2s9db7560      debug   #queue = 1
Oct 06 21:43:07 c2s9db7560      debug   Queuing <r> (in a moment)
Oct 06 21:43:07 c2s9db7560      debug   Handled 2 incoming stanzas
Oct 06 21:43:07 c2s9db7560      debug   Received[c2s]: <iq id='monal89383' type='get' to='xmpp.eightysoft.de'>
Oct 06 21:43:07 c2s9db7560      debug   #queue = 2
Oct 06 21:43:07 c2s9db7560      debug   Handled 3 incoming stanzas
Oct 06 21:43:07 c2s9db7560      debug   Received[c2s]: <iq id='monal89383' type='get' to='xmpp.eightysoft.de'>
Oct 06 21:43:07 c2s9db7560      debug   #queue = 3
Oct 06 21:43:07 c2s9db7560      debug   Handled 4 incoming stanzas
Oct 06 21:43:07 c2s9db7560      debug   Received[c2s]: <iq id='monal89383' type='get'>

You should use uuids as stanza ids to avoid all sorts of id clashes.

[anurodhp]

good catch. ancient code. switching to UUID

[tmolitor-stud-tu]

very nice, thanks!!