Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation building fails #697

Closed
glass-ships opened this issue May 20, 2024 · 1 comment
Closed

Documentation building fails #697

glass-ships opened this issue May 20, 2024 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@glass-ships
Copy link
Collaborator

glass-ships commented May 20, 2024

See: https://github.com/monarch-initiative/monarch-app/actions/runs/9162622459/job/25189970629

make docs, specifically the step:
typer backend/src/monarch_py/cli.py utils docs --name monarch --output docs/Usage/CLI.md

Fails, due to "TypeError: Name 'version' defined twice"

We should really figure out why this is happening but I'm not sure where to look

EDIT:

Looks like this is also related to other commands in the solr cli, for example:
image

@glass-ships glass-ships added this to the 2024-07 Release milestone May 20, 2024
@glass-ships glass-ships added bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed labels May 20, 2024
@glass-ships
Copy link
Collaborator Author

The issue is with typer 0.12.3.
Reverting to typer 0.7 + typer-CLI for now in #725

glass-ships added a commit that referenced this issue May 31, 2024
Closes #656 and #697 

- Revert typer from 0.12.3 to 0.7 + typer-cli
- Swap `object_best_matches` for `subject_best_matches` in
`compareSetToSets`
- Add Ancestor IC to cell hover info
- Add `metric` parameter to phenogrid search and multi-compare URLs 
- Link to `phenogrid.md` from `CONTRIBUTING.md`
- [x] Update phenogrid documentation about making iframes a little
- [x] Add test for phenogrid content (@kevinschaper)
- [ ] Change example in phenotype explore / testbed (another PR? this
one?)

---------

Co-authored-by: Kevin Schaper <kevinschaper@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant