Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-compare phenogrid #725

Merged
merged 10 commits into from
May 31, 2024
Merged

Fix multi-compare phenogrid #725

merged 10 commits into from
May 31, 2024

Conversation

glass-ships
Copy link
Collaborator

@glass-ships glass-ships commented May 29, 2024

Closes #656 and #697

  • Revert typer from 0.12.3 to 0.7 + typer-cli
  • Swap object_best_matches for subject_best_matches in compareSetToSets
  • Add Ancestor IC to cell hover info
  • Add metric parameter to phenogrid search and multi-compare URLs
  • Link to phenogrid.md from CONTRIBUTING.md
  • Update phenogrid documentation about making iframes a little
  • Add test for phenogrid content (@kevinschaper)
  • Change example in phenotype explore / testbed (another PR? this one?)

Copy link

netlify bot commented May 29, 2024

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit a2d2f20
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/66591e0e5294f20008634405
😎 Deploy Preview https://deploy-preview-725--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.74%. Comparing base (84b66f5) to head (a2d2f20).

Files Patch % Lines
backend/tests/integration/test_solr_search.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #725   +/-   ##
=======================================
  Coverage   70.74%   70.74%           
=======================================
  Files          91       91           
  Lines        3073     3073           
=======================================
  Hits         2174     2174           
  Misses        899      899           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glass-ships glass-ships changed the title Fix multi-compare phenogrid (WIP) Fix multi-compare phenogrid May 30, 2024
…ches (seems to have been lost in a merge previously?)
…e request into a hardcoded fixture so that it can be shared between generating fixtures and a phenogrid data processing test. Also generated fixtures
@glass-ships glass-ships merged commit a9d9d64 into main May 31, 2024
10 of 11 checks passed
@glass-ships glass-ships deleted the fix-multi-pheno branch May 31, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Phenogrid MultiCompare results display
2 participants