Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NTR] need genetic terms #5952

Closed
nicolevasilevsky opened this issue Feb 23, 2023 · 16 comments · Fixed by #7292
Closed

[NTR] need genetic terms #5952

nicolevasilevsky opened this issue Feb 23, 2023 · 16 comments · Fixed by #7292
Assignees

Comments

@nicolevasilevsky
Copy link
Member

nicolevasilevsky commented Feb 23, 2023

Related to #5539

  • hereditary heart disease (syn: cardiogenetic)
  • hereditary kidney disease (syn: nephrogenetic)
  • hereditary neurological disease (syn: neurogenetic)
    • central neurogenetic
    • peripheral neurogenetic

hereditary syndromic disease
etc
....
def: a hereditary disease that is isolated to the specific organ system

discussed on curation call on 2023-02-23 and 2023-03-23

cc @sabrinatoro

@nicolevasilevsky
Copy link
Member Author

nicolevasilevsky commented Mar 7, 2023

there are a number of genetic grouping classes that are tagged for obsoletion, I think we should remove the obsoletion tag and reconsider if we want to obsolete these

@sabrinatoro's questions

  • what is “genetic diseases”? are they the same as “inherited”?
    • genetic does not necessarily mean mono-allelic
    • hereditary means if you have a kid, you can pass it on
  • if ordo grouped diseases based on inherited/genetic reason, do it make sense or not? I really dislike the “de-obsoletion” of terms (this has very bad consequences to users), so let’s at least think about it before obsoleting these terms.

mondo_obsoletioncandidates (8).xlsx

@nicolevasilevsky
Copy link
Member Author

nicolevasilevsky commented Mar 23, 2023

@nicolevasilevsky
Copy link
Member Author

keep an eye on this term and make sure it is not classified under monogenic class
'Usher syndrome, type 1D/F'

@pnrobinson
Copy link
Member

pnrobinson commented Mar 30, 2023

@nicolevasilevsky @ahamosh
Suggestion
label: hereditary neurological disease (syn: neurogenetic)
def: A heterogeneous group of genetic conditions, with Mendelian (autosomal dominant, recessive, or X-linked) or chromosomal etiology that are characterized by abnormalities in brain, spinal cord, nerves or muscles.
CHILD--
Label: Heritable neuromuscular disease
Definition: A heterogeneous group of genetic conditions, with Mendelian (autosomal dominant, recessive, or X-linked) or chromosomal etiology that are characterized by characterized by progressive muscle degeneration and weakness.

-- this is a good source for the hierarchy directly underneath -- https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5004840/

CHILD 2
Label: Heritable neurological disease
Definition: A heterogeneous group of genetic conditions, with Mendelian (autosomal dominant, recessive, or X-linked) or chromosomal etiology that are characterized by progressive muscle degeneration and weakness.

@pnrobinson
Copy link
Member

@nicolevasilevsky @sabrinatoro @ahamosh
Suggestion
Cardiogenetic disease
A heterogeneous group of genetic conditions, with Mendelian (autosomal dominant, recessive, or X-linked) or chromosomal etiology that are characterized by abnormalities in the cardiovascular system.PMID:32341133

@pnrobinson
Copy link
Member

@nicolevasilevsky @sabrinatoro @ahamosh
Suggestion
nephrogenetic disease syn genetic renal disease
def: A heterogeneous group of genetic conditions, with Mendelian (autosomal dominant, recessive, or X-linked) or chromosomal etiology that are characterized by abnormalities in the kidney or urinary system.
See here for top level -- https://diagnostics.medgenome.com/nephro-genetics/

@pnrobinson
Copy link
Member

@nicolevasilevsky @sabrinatoro @cmungall
sorry to be pushy but we could really use this reorganization for L4CI. If you agree to the above and would show me briefly how you would like me to do a pull request I can work on this or maybe we can do a hacking session?

@nicolevasilevsky
Copy link
Member Author

nicolevasilevsky commented Mar 30, 2023

Hi Peter -
we can definitely get these terms in for the next release.

  1. I can add these myself tomorrow
  2. You can add them yourself on a branch using Protege and do a PR, you have an ID range (see below) (here are instructions on how to do a PR in Mondo: https://mondo.readthedocs.io/en/latest/editors-guide/d-github-pr-workflow/)

Datatype: idrange:15

    Annotations: 
        allocatedto: "Peter Robinson"

    EquivalentTo: 
        xsd:integer[>=0100000, <= 1000999]
  1. You can add them via our new bulk request form, instructions are here: https://mondo.readthedocs.io/en/latest/editors-guide/bulk-request/
  2. You can also use KGCL to add new terms (this is new, we've only done some minimal testing with this, but it seemed to work for me when I tried it): https://mondo.readthedocs.io/en/latest/editors-guide/make-simple-changes/

@nicolevasilevsky
Copy link
Member Author

since this is urgent, I'll plan to add these myself tomorrow if I don't hear back. But you are welcome to directly edit Mondo on a branch and make a PR anytime. Let us know if any of the instructions linked above are not clear and if you'd like one of us to walk you through the process on a call.

@pnrobinson
Copy link
Member

@nicolevasilevsky -- I will do a PR, but prob will only get to it on Sat AM! We also need to rearrange some of the existing terms that are hereditary!

@nicolevasilevsky
Copy link
Member Author

ok, fantastic! @sabrinatoro plans to run the release on Monday. @sabrinatoro if you get to it before I do, could you review and merge Peter's PRs, so they get in to this next release?

Or we can push the release back one day too. We don't want to make you wait another month.

@nicolevasilevsky
Copy link
Member Author

nicolevasilevsky commented Apr 6, 2023

to do:

  • need non-inherited class for 'focal segmental glomerulosclerosis' (note NCIT def seems to be isolated or primary) - MONDO:0005363
  • 'essential hypertension, genetic' is a susceptibility
  • obsolete 'genetic hypertension'
  • review children of 'secondary glomerular disease'
  • need non-inherited class for 'hemolytic-uremic syndrome'
  • add 'hypertensive nephropathy' to the OMIM omit list or revise to a mendelian form (ask Ada)

@nicolevasilevsky nicolevasilevsky added this to the July release milestone May 19, 2023
@nicolevasilevsky
Copy link
Member Author

nicolevasilevsky commented Jun 21, 2023

Updated 2023-06-20

Open Action items

  • add 'hypertensive nephropathy' to the OMIM omit list (does this mean we want to obsolete this term?) or revise to a mendelian form (ask Ada)
  • add new terms (confirm with Peter):
    • label: hereditary neurological disease (syn: neurogenetic)
      def: A heterogeneous group of genetic conditions with Mendelian (autosomal dominant, recessive, or X-linked) or chromosomal etiology characterized by abnormalities in the brain, spinal cord, nerves, or muscles.
    • Label: heritable neuromuscular disease
      parent: hereditary neurological disease
      Definition: A heterogeneous group of genetic conditions with Mendelian (autosomal dominant, recessive, or X-linked) or chromosomal etiology that is characterized by progressive muscle degeneration and weakness.
      • review this article for children of neuromuscular diseases: https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5004840/
        - [ ] Add term:
        Label: Heritable neurological disease
        Definition: A heterogeneous group of genetic conditions, with Mendelian (autosomal dominant, recessive, or X-linked) or chromosomal etiology that are characterized by progressive muscle degeneration and weakness.

        this is duplicated with the term above
    • Add term: Cardiogenetic disease
      A heterogeneous group of genetic conditions, with Mendelian (autosomal dominant, recessive, or X-linked) or chromosomal etiology that are characterized by abnormalities in the cardiovascular system.PMID:32341133

@nicolevasilevsky
Copy link
Member Author

@pnrobinson FYI, I'll proceed with these action items above.

nicolevasilevsky added a commit that referenced this issue Jun 27, 2023
close #6381

@sabrinatoro note, I am removing obsoletion tags from genetic terms, because based on our conversations with Peter, we want to keep these.
related: #5952
nicolevasilevsky added a commit that referenced this issue Jun 27, 2023
nicolevasilevsky added a commit that referenced this issue Jun 27, 2023
* relabel terms to hereditary instead of genetic

close #6381

* revise labels to be hereditary instead of genetic

close #6381

@sabrinatoro note, I am removing obsoletion tags from genetic terms, because based on our conversations with Peter, we want to keep these.
related: #5952

* revise labels

* revise labels

* revise labels

* revise labels

* relabel hereditary terms

* fix typo
@nicolevasilevsky nicolevasilevsky added Ada/Peter Question for Ada and/or peter blocked Something needs to be done before work can proceed labels Jul 25, 2023
@nicolevasilevsky
Copy link
Member Author

Updated 2023-08-08

We will address this after we do the mass ORDO obsoletion.

Note to self, add this term:

[Term]
id: MONDO:0100521
name: hereditary neurological disease
def: "A heterogeneous group of genetic conditions with Mendelian (autosomal dominant, recessive, or X-linked) or chromosomal etiology characterized by abnormalities in the brain, spinal cord, nerves, or muscles." [https://orcid.org/0000-0002-0736-9199]
synonym: "neurogenetic disease" EXACT [https://orcid.org/0000-0002-0736-9199]
is_a: MONDO:0005071 {source="https://orcid.org/0000-0002-0736-9199"} ! nervous system disorder
intersection_of: MONDO:0005071 ! nervous system disorder
intersection_of: has_characteristic MONDO:0021152 ! inherited
property_value: http://purl.org/dc/terms/creator https://orcid.org/0000-0001-5208-3432
property_value: IAO:0000233 "#5952" xsd:anyURI

@nicolevasilevsky
Copy link
Member Author

add 'hypertensive nephropathy' to the OMIM omit list or revise to a mendelian form (ask Ada)

this is already a child of 'hereditary disease', so it is inferred to be a Mendelian form. I will leave this for now.

nicolevasilevsky added a commit that referenced this issue Feb 16, 2024
- hereditary neurological disease
- hereditary neuromuscular disease

close #5952
sabrinatoro pushed a commit that referenced this issue Feb 16, 2024
* add new genetic terms

- hereditary neurological disease
- hereditary neuromuscular disease

close #5952

* add term cardiogenetic disease
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants