Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new term MONDO:0100089 #1037

Merged
merged 2 commits into from
Apr 3, 2020
Merged

add new term MONDO:0100089 #1037

merged 2 commits into from
Apr 3, 2020

Conversation

nicolevasilevsky
Copy link
Member

closes #1018

cmungall
cmungall requested changes Dec 13, 2019
View reviewed changes
Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the relationship to the 4 OMIM diseases for GATA1?

https://omim.org/entry/305371

Is this a superclass of all of these?

there should presumably be some relationship

we need to add a SOP to manual for adding new gene-centric diseases, how we relate these to omim

@nicolevasilevsky nicolevasilevsky self-assigned this Dec 17, 2019
@cmungall
Copy link
Member

see Q above

@nicolevasilevsky nicolevasilevsky removed their assignment Jan 28, 2020
@nicolevasilevsky
Copy link
Member Author

Per the ticket, I added subclasses to this term.

I'll create a ticket re: we need to add a SOP to manual for adding new gene-centric diseases, how we relate these to omim

@nicolevasilevsky nicolevasilevsky mentioned this pull request Jan 28, 2020
Closed
@nicolevasilevsky nicolevasilevsky self-assigned this Mar 26, 2020
@nicolevasilevsky nicolevasilevsky merged commit 5577982 into master Apr 3, 2020
@nicolevasilevsky nicolevasilevsky deleted the issue-1018 branch April 3, 2020 17:19
@miajsullivan miajsullivan mentioned this pull request Apr 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmungall cmungall cmungall requested changes

Assignees

@ShahimEssaid ShahimEssaid

@nicolevasilevsky nicolevasilevsky

Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NTR]GATA1-Related X-Linked Cytopenia
3 participants
@nicolevasilevsky @cmungall @ShahimEssaid