Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporting SSSOM mappings #3058

Merged
merged 42 commits into from
Mar 7, 2022
Merged

Exporting SSSOM mappings #3058

merged 42 commits into from
Mar 7, 2022

Conversation

matentzn
Copy link
Member

@matentzn matentzn commented May 13, 2021 •
edited
Loading

Outstanding action items:

cmungall
cmungall reviewed May 21, 2021
View reviewed changes
Copy link
Member

@cmungall cmungall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we include more

  • more info in headers
    • separate date when mappings were made vs exported
    • versions of ontologies
  • more info in rows
    • labels
    • (later) some boomer stats

@matentzn matentzn marked this pull request as ready for review May 21, 2021 17:53
@matentzn matentzn changed the title WIP: exporting SSSOM mappings Exporting SSSOM mappings May 21, 2021
hrshdhgd
hrshdhgd reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@hrshdhgd hrshdhgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Are there tests for this?

@matentzn matentzn marked this pull request as ready for review February 23, 2022 18:17
@joeflack4
Copy link
Collaborator

@matentzn 49 files changed! Are you just wanting me to review the .py files mainly?

@hrshdhgd
Copy link
Member

Hey @joeflack4 , I'll let Nico answer but 47 of the 49 are sssom TSVs generated. Just thought of letting you know.

@matentzn matentzn mentioned this pull request Feb 24, 2022
Open
1 task
@matentzn matentzn added this to Mondo clean-up in Mondo - ICD Mapping Feb 24, 2022
@nicolevasilevsky
Copy link
Member

note to self, I don't need to review this

@matentzn
Copy link
Member Author

matentzn commented Feb 25, 2022 •
edited
Loading

EDIT: Moved contents of this comment to the first comment in the PR.

@matentzn
Copy link
Member Author

matentzn commented Feb 25, 2022 •
edited
Loading

Moved contens of this comment to the first comment in the PR.

@nicolevasilevsky nicolevasilevsky marked this pull request as draft March 3, 2022 16:21
@matentzn matentzn marked this pull request as ready for review March 7, 2022 17:20
@matentzn matentzn merged commit 7ddddba into master Mar 7, 2022
@matentzn matentzn deleted the sssom-rewrite branch March 7, 2022 17:38
@hrshdhgd hrshdhgd restored the sssom-rewrite branch March 7, 2022 23:39
@hrshdhgd
Copy link
Member

hrshdhgd commented Mar 7, 2022

restoring this branch again. Have addressed mapping-commons/sssom-py#214 and fix applied to this branch for new mappings.

@matentzn matentzn removed this from Mondo clean-up in Mondo - ICD Mapping Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmungall cmungall cmungall left review comments

@hrshdhgd hrshdhgd hrshdhgd left review comments

@joeflack4 joeflack4 Awaiting requested review from joeflack4

@nicolevasilevsky nicolevasilevsky Awaiting requested review from nicolevasilevsky

Assignees

@hrshdhgd hrshdhgd

Labels
high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matentzn @joeflack4 @hrshdhgd @nicolevasilevsky @cmungall