Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attention box: when the prop "title" is undefined do not draw the "monday-style-attention-box-component__title-container" #273

Closed
hadasfa opened this issue Oct 14, 2021 · 4 comments

Comments

@hadasfa
Copy link
Contributor

hadasfa commented Oct 14, 2021

please add screenshot or video on the pr when the prop "title" is empty and with value

@pedaars
Copy link
Contributor

pedaars commented Oct 14, 2021

I can take a look at this

@pedaars
Copy link
Contributor

pedaars commented Oct 14, 2021

do you want this to be undefined or an empty string?
or just empty string rather than undefined?
so with title text
image

and with empty string
image

@pedaars
Copy link
Contributor

pedaars commented Oct 15, 2021

@hadasfa I have a pr to submit once the above questions have been confirmed.
I think what you meant was empty string instead of undefined as the default title prop is an empty string?

@hadasfa
Copy link
Contributor Author

hadasfa commented Oct 20, 2021

@pedaars @pedaars Hey, sorry for the late reply. I would like that the title will not be drawn for empty string and for undefined.

@hadasfa hadasfa closed this as completed Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants