Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Italian quickfacts design edits and links corrections #40

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Conversation

lh1008
Copy link
Contributor

@lh1008 lh1008 commented Nov 1, 2018

Hi @erciccione,

Did some design edits and removed some links and left them the same as the original English links version.

@hrumag thanks a lot for your work. You can take a look at how the final version came out. :).

Thank you all.

@hrumag
Copy link
Contributor

hrumag commented Nov 2, 2018 via email

Copy link
Contributor

@hrumag hrumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lh1008, I've found some little mistakes that should be fixed. Probably they were already present.

  • "Fungibilità" Section

Le unità di Moneronon possono essere discriminate daivenditori o dagli exchange
per la loro origine o storia.

Two spaces should be inserted: "Moneronon" -> "Monero non", "daivenditori" -> "dai venditori"

  • "Storia di Monero" Section

[...] tenendo anche conto

One space should be removed between "tenendo" and "conto".

  • "Tratti distintivi => traiettoria della ricompensa di blocco"

L'emissione di coda manterrà un constante ed [...]

s/constante/costante

  • "Funzionalità in fase di sviluppo => Kovri

Ogni strato di una transazione Monero, il mittente, il destinatario, l'ammontare della tranzazione [...]

s/tranzazione/transazione

Thank you.

@lh1008
Copy link
Contributor Author

lh1008 commented Nov 2, 2018

@hrumag what do you mean with this one? What would the final words look like?

"Storia di Monero" Section

[...] tenendo anche conto

One space should be removed between "tenendo" and "conto".

  • tenendoanche conto?
  • tenendo ancheconto?

@hrumag
Copy link
Contributor

hrumag commented Nov 3, 2018

  • tenendoanche conto?
  • tenendo ancheconto?

Sorry @lh1008 I made a mistake at the point.
The correct form is "tenendo anche conto" (in English is "also taking into account").
It seems in the version under review there are two spaces between "tenendo" and "anche"

Sorry again.

@lh1008
Copy link
Contributor Author

lh1008 commented Nov 4, 2018

Thank you @hrumag, I didn't understand. Maybe I was to lazy to look. I will doing the commit right away with the corrections. Thank you :). 👍

@lh1008
Copy link
Contributor Author

lh1008 commented Nov 4, 2018

@hrumag did the corrections. Thank you again. Could you please approve the changes :).

@erciccione this just needs approval to merge.

Thank you guys.

@erciccione erciccione merged commit 1a573f2 into monero-ecosystem:master Nov 5, 2018
@lh1008
Copy link
Contributor Author

lh1008 commented Nov 7, 2018

Thank you @erciccione.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants