Remote nodes + mobile layout #826

Jaqueeee · 2017-08-21T05:54:48Z

basically everything in #780 except the things depending off monero-project/monero#2109

mobile layout + android optimizations
use-remote-node-while-syncing-local-daemon
blockchain folder settings
lots of small improvements

know issues: monerod fast sync updates has made the daemon less responsive while syncing. This can cause a couple of seconds freeze in the gui occasionally. I'm working on making the affected rpc calls asynchronous.

Jaqueeee · 2017-08-24T08:22:16Z

Rebased and fixed conflicts

SamsungGalaxyPlayer · 2017-08-24T19:18:51Z

@Jaqueeee this is amazing. Thank you so much for your hard work.

Jaqueeee · 2017-10-27T16:17:39Z

rebased again.

moneromooo-monero · 2017-11-02T17:30:16Z

LeftPanel.qml

@@ -441,6 +446,7 @@ Rectangle {
            // ------------- Sign/verify tab ---------------
            MenuButton {
                id: signButton
+                visible: !isAndroid && !isIOS


Why would you want to disable signing/verifying a message on those ?

The layout on that page didn't look OK on smaller screens. fixed now. Enabling.

moneromooo-monero · 2017-11-02T17:31:54Z

RightPanel.qml

 // 2. Redistributions in binary form must reproduce the above copyright notice, this list
 //    of conditions and the following disclaimer in the documentation and/or other
 //    materials provided with the distribution.
-// 
+//


Plenty of spurious changes

moneromooo-monero · 2017-11-02T17:32:44Z

RightPanel.qml

+////        anchors.fill: parent
+////        source: parent
+////        desaturation: root.enabled ? 0.0 : 1.0
+////    }


That seems to be a temporary bodge, right ? Not that I think twitter stuff has anything to do in a wallet though.

Agree. It doesn't belong in the wallet. that's why i commented it out. But i might as well delete it permanently?

removed all twitter junk

moneromooo-monero · 2017-11-02T17:34:09Z

components/HistoryTable.qml

@@ -383,7 +375,7 @@ ListView {
            Column {
                anchors.top: parent.top
                width: 148
-                visible: isOut
+                visible: isOut && fee != ""


That seems odd. Could it hide valid txes if the fee isn't properly saved ?

It hides the fee instead of showing it as "0.00000000". The amount column would still be visible. Reason is MyMonero shows amount+fee baked together

moneromooo-monero · 2017-11-02T17:37:03Z

components/MobileHeader.qml

        anchors.verticalCenter: parent.verticalCenter
        anchors.verticalCenterOffset: -5
        anchors.left: parent.left
-        anchors.leftMargin: appWindow.persistentSettings.customDecorations ? 20 : 40
+        anchors.leftMargin: 50 * scaleRatio //appWindow.persistentSettings.customDecorations ? 20 * scaleRatio: 40 * scaleRatio


Is that meant to ignore the bool now ? If so, could be removed

moneromooo-monero · 2017-11-02T18:29:04Z

wizard/WizardDaemonSettings.qml

+            CheckBox {
+                id: remoteNode
+                text: (localNode.checked) ? qsTr("Connect to a 3rd party remote node until my own node has finished syncing") + translationManager.emptyString
+                                          : qsTr("Connect to a 3rd party remote node") + translationManager.emptyString


I'd remove 3rd party since it doesn't have to be. Doesn't really matter though.

moneromooo-monero · 2017-11-02T18:29:26Z

wizard/WizardDaemonSettings.qml

+                Layout.minimumWidth: 300 * scaleRatio
+                opacity: remoteNode.checked
+                id: remoteNodeEdit
+                daemonAddrText: persistentSettings.remoteNodeAddress.split(":")[0]


Same comment about trimming being possibly needed

moneromooo-monero · 2017-11-02T18:30:28Z

wizard/WizardManageWalletUI.qml

@@ -86,15 +86,40 @@ ColumnLayout {
        return wordsArray.length === 25
    }

+    function updateFromQrCode(address, payment_id, amount, tx_description, recipient_name, extra_parameters) {
+        // Switch to recover from ke    ys


moneromooo-monero · 2017-11-02T18:33:14Z

wizard/WizardPasswordUI.qml

-          strength = 100
-      // privacyLevel component uses 1..13 scale
-      privacyLevel.fillLevel = Utils.mapScope(1, 100, 1, 13, strength)      
+      // TODO: password strength meter segfaults on Android.


Any stack trace for this ?

Initially reported by @MoroccanMalinois, do you have a stack trace for this? I don't have access to any android devices at the moment.

moneromooo-monero · 2017-11-02T18:33:38Z

wizard/WizardPasswordUI.qml

-      // privacyLevel component uses 1..13 scale
-      privacyLevel.fillLevel = Utils.mapScope(1, 100, 1, 13, strength)      
+      // TODO: password strength meter segfaults on Android.
+      if (!isMobile) {


And maybe allow it on IOS then

enabled on iOS

Jaqueeee · 2017-11-03T17:22:10Z

@moneromooo-monero pushed again

Remote nodes + mobile layout

jluttine · 2017-12-08T05:19:29Z

Will this become available in F-Droid?

Jaqueeee mentioned this pull request Aug 21, 2017

Change default testnet rpc port to 28081 #797

Closed

Jaqueeee force-pushed the remote-nodes branch from f8bb23e to e21dd7c Compare August 24, 2017 08:22

This was referenced Sep 5, 2017

Seed & keys popup window not stylized properly #862

Closed

Inconsistent capital letter settings page - styling #861

Closed

Jaqueeee force-pushed the remote-nodes branch 2 times, most recently from 24648bd to cbc9196 Compare October 27, 2017 15:09

Jaqueeee mentioned this pull request Oct 27, 2017

Lightwallet support + mobile redesign (no merge) #780

Closed

Jaqueeee added 7 commits November 1, 2017 17:02

QrCodeScanner: parse extra parameters

77335b3

delete addressbook in wallet destructor

d78f9f5

add localDaemonSynced()

8553771

transactionInfo: use empty str when fee=0

c72207c

add scaleRatio property and isAndroid

7af8383

Wizard: add scaleRatio

91953f1

wizard: use m_wallet instead of storing in settingsObj

bbcb780

moneromooo-monero reviewed Nov 2, 2017

View reviewed changes

Jaqueeee added 12 commits November 3, 2017 16:09

Wizard: add daemon settings page

a3088b1

Wizard: add qrcode scanner to recover page

b205acc

wizard: reworked testnet settings

bcb7bcf

wizard: disable password strenght meter on mobiles

0e6028a

checkbox redesign

085dfe1

historyTable mobile layout

abd5f50

Add Keys page

603c1e7

Leftpanel scaling/mobile layout

855f206

mobile: hide mining, sign/verify pages

316ddf1

MiddlePanel scaling

a57da2f

android fix: release focus after scrolling

44079aa

Remove twitter stuff from rightpanel

01899f0

Jaqueeee added 21 commits November 3, 2017 16:57

History: use mobile layout

c1c6d9e

Receive page mobile layout fix

d834fb4

Sign page - redesign

aded122

Transfer - mobile redesign

58030c6

AddressBook mobile redesign

72d2204

Android: handle back-button + add statusBox

b915228

Add blockchain folder FileDialog

3d21b11

don't close async

b8f38f2

refresh history updates

44b72ea

new dialog z fixes

e324e16

fix popups positioning

4b87130

start local node if not started

e6ada22

Improve copy text handling

2170f6a

history table - improved mobile layout

394b20e

IOS open from file workaround

a72a76d

Keys page height fix

2d357b6

Menu button color fix

0946139

Add ios files to .gitignore

bfafd7b

mobile layout tweaks

4775a5b

trim daemon address

15ea9ec

Enable password strength meter on iOS

a8e19b8

Jaqueeee force-pushed the remote-nodes branch from cbc9196 to a8e19b8 Compare November 3, 2017 15:57

Jaqueeee added 2 commits November 3, 2017 17:02

Enable sign/verify on ios/android

3c67b9e

do not try to start local node automatically if user has cancelled

ceeb9b6

moneromooo-monero approved these changes Nov 3, 2017

View reviewed changes

luigi1111 merged commit ceeb9b6 into monero-project:master Nov 3, 2017

luigi1111 added a commit that referenced this pull request Nov 3, 2017

Merge pull request #826

c58dfa9

Remote nodes + mobile layout

stoffu mentioned this pull request Nov 16, 2017

Wallet password dialog refactoring + allow password to be changed #889

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remote nodes + mobile layout #826

Remote nodes + mobile layout #826

Jaqueeee commented Aug 21, 2017

Jaqueeee commented Aug 24, 2017

SamsungGalaxyPlayer commented Aug 24, 2017

Jaqueeee commented Oct 27, 2017

moneromooo-monero Nov 2, 2017

Jaqueeee Nov 3, 2017

moneromooo-monero Nov 2, 2017

Jaqueeee Nov 3, 2017

moneromooo-monero Nov 2, 2017

Jaqueeee Nov 2, 2017

Jaqueeee Nov 3, 2017

moneromooo-monero Nov 2, 2017

Jaqueeee Nov 2, 2017

moneromooo-monero Nov 2, 2017

Jaqueeee Nov 3, 2017

moneromooo-monero Nov 2, 2017

Jaqueeee Nov 3, 2017

moneromooo-monero Nov 2, 2017

Jaqueeee Nov 3, 2017

moneromooo-monero Nov 2, 2017

Jaqueeee Nov 3, 2017

moneromooo-monero Nov 2, 2017

Jaqueeee Nov 3, 2017

moneromooo-monero Nov 2, 2017

Jaqueeee Nov 3, 2017

Jaqueeee commented Nov 3, 2017

jluttine commented Dec 8, 2017

Remote nodes + mobile layout #826

Remote nodes + mobile layout #826

Conversation

Jaqueeee commented Aug 21, 2017

Jaqueeee commented Aug 24, 2017

SamsungGalaxyPlayer commented Aug 24, 2017

Jaqueeee commented Oct 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jaqueeee commented Nov 3, 2017

jluttine commented Dec 8, 2017