Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch stations from SomaFM api #20

Merged
merged 6 commits into from
Nov 1, 2015

Conversation

code-for-coffee
Copy link
Contributor

I have modified popup.coffee and popup.haml to automatically fetch channel listings from the SomaFM API. They are fetched when a new instance of SomaPlayer() is instantiated.

@cheshire137
Copy link
Owner

I'm trying this out now! Thanks!

@@ -0,0 +1,6 @@
var SomaPlayerConfig = {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file could be deleted. config.js.example is in the root directory, but config.js should end up in extension/.

@cheshire137
Copy link
Owner

I'll take it! I'll make it fall back to a hardcoded list if the JSON errors out, so the user should still see most stations regardless. Thanks!

cheshire137 added a commit that referenced this pull request Nov 1, 2015
Fetch stations from SomaFM api
@cheshire137 cheshire137 merged commit 7e17c40 into cheshire137:master Nov 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants