Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video locking feature. #28

Closed
iBabu007 opened this issue Jan 16, 2021 · 6 comments
Closed

Add video locking feature. #28

iBabu007 opened this issue Jan 16, 2021 · 6 comments

Comments

@iBabu007
Copy link

Please add video locking feature.
You can't change anything (slider & volume & brightness bar) until you unlock.

@Pentaphon
Copy link

Pentaphon commented Jan 19, 2021

Already requested here: #1

@moneytoo
Copy link
Owner

In version 0.22 (currently pre-release) I'm adding related feature that partly deals with accidental touches: Seek in time bar only using scrubber (thumb). This doesn't lock any other gestures but it should prevent the worst kind of accidental taps in my opinion (like skipping somewhere in the video without remembering previous position).

@moneytoo
Copy link
Owner

moneytoo commented Jul 8, 2021

Here's a preview version with temporary touch locking feature: Just.Player.v0.42-touch_lock.apk

To lock, do a long press (anywhere outside other controls) when video plays. To unlock, just long press anywhere again.

Do you think it can work like that? This is how I prefer it (I do not want to hunt small button on a screen when I want/need to quickly stop the playback). I have almost never used such functionality... But with such seamless activation/deactivation, I see myself using it when wiping dirt of the screen now.

@Pentaphon
Copy link

Pentaphon commented Jul 9, 2021

To lock, do a long press (anywhere outside other controls) when video plays. To unlock, just long press anywhere again.

That's more than enough as long as there's an gesture icon/text that shows "Locked" when you lock it and "unlocked" when you unlock it.

I agree with not adding another button.

@moneytoo
Copy link
Owner

moneytoo commented Jul 9, 2021

Yes, there are padlock icon indicators for locking/unlocking. I also added one more unlock method - tapping the lock icon. This should serve as a backup unlock for users who inadvertently activate the lock (without realizing they long tapped).

(I don't feel like the app should necessarily describe all the control gestures during onboarding but I would like to have one screenshot explaining all the possible touch gestures - some common like swipes and double taps as well as this little awkward long press for locking.)

@moneytoo
Copy link
Owner

Already fully available in the release v0.42.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants