Bump required C driver to 1.25.0 #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Ubuntu 18.04 with minimum libmongoc" was removed in PR mongodb#1049. Testing with minimum libmongoc is now the default.
This step is listed in later in `Docker Image Build and Publish`. Building the Docker images requires downloading the C++ release tarball. Bump after tagging.
The Docker versions are bumped after tagging the release. This check may not be expected to succeed during a release.
It is introduced in 3.9.0 as part of CXX-2695.
This is a workaround until CDRIVER-4776 is resolved.
|
Updating to C driver 1.25.0 resulted in an error building example projects with pkg-config using the static libraries. e9f0f9d applies a workaround. CDRIVER-4776 tracks a fix in the C driver. |
kkloberdanz
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps the required C driver to 1.25.0 and includes additional changes intended before the 3.9.0 release:
check_docker_file_versions.-pthreadto pkg-config example projects to work around CDRIVER-4776Background & Motivation
Updating
MONGOCXX_VERSIONin Dockerfile before tagging a release may result in error downloading the not-yet-released tarball. This PR assumes it is preferable to update versions in the Dockerfiles after tagging a release.