OpenSSL 1.1.x compilation fixes for "legacy" branch #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this would just encourage people to continue to use the legacy driver as they find their OpenSSL versions upgraded, so I don't think we should merge it. Still, I appreciate your mentioning it on the associated ticket, as that should get people here. On the other hand, I'd rather not leave PRs open forever, and I'm not merging it because, as you note, the driver is EOL. So, I think it is best to close it, but I think you have left enough breadcrumbs that doing so won't remove its value. Let me know if you strongly disagree. |
|
Closing, driver is EOL. |
|
@kedazo Thanks for this. Resurrected an old project and this came in handy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
Yes I am aware about that this branch shouldn't be used anylonger, however i made some small mods which makes this compilable with OpenSSL 1.1.x.
These are very little mods, maybe someone is interested.
Br,
David