simplify logic

mongodb · Nov 11, 2010 · 5e81cf2 · 5e81cf2
1 parent 4a1bcce
commit 5e81cf2
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/lib/bson/types/object_id.rb b/lib/bson/types/object_id.rb
@@ -53,10 +53,7 @@ def initialize(data=nil)
     #
     # @return [Boolean]
     def self.legal?(str)
-      len = 24
-      str =~ /([0-9a-f]+)/i
-      match = $1
-      str && str.length == len && match == str
+      str =~ /^[0-9a-f]{24}$/i ? true : false
     end
 
     # Create an object id from the given time. This is useful for doing range