RUBY-900 Don't add discovered servers to the cluster with Single topology #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,7 +66,7 @@ def ==(other) | |||
| # @since 2.0.0 | |||
| def add(host) | |||
| address = Address.new(host) | |||
| unless addresses.include?(address) | |||
| unless addresses.include?(address) || (@topology.single? && address.seed != @topology.seed) | |||
There was a problem hiding this comment.
@durran This line can probably be improved, let me know if you have any other ideas.
There was a problem hiding this comment.
I would probably change the logic to to make it a bit less confusing as well as extracting a method on the second part...
if !addresses.include?(address) || direct_connection?(address)
#...
end
|
I believe that would fix it! |
|
cool, thanks so much for helping out @jeromegn ! |
estolfo
force-pushed
the
RUBY-900-single-top
branch
from
2c8483e
to
b4c4a89
Compare
estolfo
added a commit
that referenced
this pull request
Apr 27, 2015
RUBY-900 Don't add discovered servers to the cluster with Single topology
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.