Bring Socket::SSL#readbyte in line with Socket / IO#readbyte #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by returning an Integer byte rather than a String and raising EOFError if EOF was reached. This unifies #readbyte across SSL and non-SSL connections. [also see mongodb/bson-ruby#44]
durran
added a commit
that referenced
this pull request
Oct 8, 2015
Bring Socket::SSL#readbyte in line with Socket / IO#readbyte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IO#readbyte – and thus Mongo::Socket#readbyte – behave as follows:
Mongo::Socket::SSL overrides this to simply call OpenSSL::Buffering resp. IO#read which behave markedly different:
nilif EOF was reached before then.This patch brings Mongo::Socker::SSL#readbyte in line with IO#readbyte thus unifying #readbyte behaviour across all socket types in this driver.
The difference in behaviour between SSL and non-SSL connections led to bugs such as https://jira.mongodb.org/browse/RUBY-1048. Also see mongodb/bson-ruby#44 for a previous workaround for a specific edge-case. This patch however fixes the root cause.