SERVER-13824: Remove some typing violations from the v8 code

Code will now work correctly with GCC 4.9.x with full optimization.

src/third_party/v8-3.25/src/globals.h

@@ -61,20 +61,20 @@ namespace internal {
 // V8_HOST_ARCH_IA32 on both 32- and 64-bit x86.
 #define V8_HOST_ARCH_IA32 1
 #define V8_HOST_ARCH_32_BIT 1
-#define V8_HOST_CAN_READ_UNALIGNED 1
+// (SERVER-13824) #define V8_HOST_CAN_READ_UNALIGNED 1
 #else
 #define V8_HOST_ARCH_X64 1
 #define V8_HOST_ARCH_64_BIT 1
-#define V8_HOST_CAN_READ_UNALIGNED 1
+// (SERVER-13824) #define V8_HOST_CAN_READ_UNALIGNED 1
 #endif  // __native_client__
 #elif defined(_M_IX86) || defined(__i386__)
 #define V8_HOST_ARCH_IA32 1
 #define V8_HOST_ARCH_32_BIT 1
-#define V8_HOST_CAN_READ_UNALIGNED 1
+// (SERVER-13824) #define V8_HOST_CAN_READ_UNALIGNED 1
 #elif defined(__AARCH64EL__)
 #define V8_HOST_ARCH_ARM64 1
 #define V8_HOST_ARCH_64_BIT 1
-#define V8_HOST_CAN_READ_UNALIGNED 1
+// (SERVER-13824) #define V8_HOST_CAN_READ_UNALIGNED 1
 #elif defined(__ARMEL__)
 #define V8_HOST_ARCH_ARM 1
 #define V8_HOST_ARCH_32_BIT 1

src/third_party/v8-3.25/src/objects.cc

@@ -8728,6 +8728,7 @@ static inline bool CompareRawStringContents(const Char* const a,
                                             const Char* const b,
                                             int length) {
   int i = 0;
+#if 0 // (SERVER-13824)
 #ifndef V8_HOST_CAN_READ_UNALIGNED
   // If this architecture isn't comfortable reading unaligned ints
   // then we have to check that the strings are aligned before
@@ -8750,6 +8751,7 @@ static inline bool CompareRawStringContents(const Char* const a,
 #ifndef V8_HOST_CAN_READ_UNALIGNED
   }
 #endif
+#endif // (SERVER-13824)
   // Compare the remaining characters that didn't fit into a block.
   for (; i < length; i++) {
     if (a[i] != b[i]) {

src/third_party/v8/src/globals.h

@@ -69,19 +69,19 @@ namespace internal {
 #if defined(_M_X64) || defined(__x86_64__)
 #define V8_HOST_ARCH_X64 1
 #define V8_HOST_ARCH_64_BIT 1
-#define V8_HOST_CAN_READ_UNALIGNED 1
+// (SERVER-13824) #define V8_HOST_CAN_READ_UNALIGNED 1
 #elif defined(_M_IX86) || defined(__i386__)
 #define V8_HOST_ARCH_IA32 1
 #define V8_HOST_ARCH_32_BIT 1
-#define V8_HOST_CAN_READ_UNALIGNED 1
+// (SERVER-13824) #define V8_HOST_CAN_READ_UNALIGNED 1
 #elif defined(__ARMEL__)
 #define V8_HOST_ARCH_ARM 1
 #define V8_HOST_ARCH_32_BIT 1
 // Some CPU-OS combinations allow unaligned access on ARM. We assume
 // that unaligned accesses are not allowed unless the build system
 // defines the CAN_USE_UNALIGNED_ACCESSES macro to be non-zero.
 #if CAN_USE_UNALIGNED_ACCESSES
-#define V8_HOST_CAN_READ_UNALIGNED 1
+// (SERVER-13824) #define V8_HOST_CAN_READ_UNALIGNED 1
 #endif
 #elif defined(__MIPSEL__)
 #define V8_HOST_ARCH_MIPS 1

src/third_party/v8/src/objects.cc

@@ -6876,9 +6876,10 @@ template <typename Char>
 static inline bool CompareRawStringContents(Vector<Char> a, Vector<Char> b) {
   int length = a.length();
   ASSERT_EQ(length, b.length());
-  const Char* pa = a.start();
-  const Char* pb = b.start();
+// (SERVER-13824)   const Char* pa = a.start();
+// (SERVER-13824)   const Char* pb = b.start();
   int i = 0;
+#if 0 // (SERVER-13824)
 #ifndef V8_HOST_CAN_READ_UNALIGNED
   // If this architecture isn't comfortable reading unaligned ints
   // then we have to check that the strings are aligned before
@@ -6901,6 +6902,7 @@ static inline bool CompareRawStringContents(Vector<Char> a, Vector<Char> b) {
 #ifndef V8_HOST_CAN_READ_UNALIGNED
   }
 #endif
+#endif // (SERVER-13824)
   // Compare the remaining characters that didn't fit into a block.
   for (; i < length; i++) {
     if (a[i] != b[i]) {