leak fix for new jni methods

mongodb · Sep 18, 2008 · 9ea5237 · 9ea5237
1 parent 8216dc6
commit 9ea5237
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/db/javajs.cpp b/db/javajs.cpp
@@ -300,7 +300,7 @@ int JavaJSImpl::scopeSetObject( jlong id , const char * field , JSObj * obj ){
   _getEnv()->DeleteLocalRef( s1 );
   if ( bb )
     _getEnv()->DeleteLocalRef( bb );
-
+  
   return res;  
 }
 
@@ -310,18 +310,22 @@ int JavaJSImpl::scopeInit( jlong id , JSObj * obj ){
 
   jobject bb = _getEnv()->NewDirectByteBuffer( (void*)(obj->objdata()) , (jlong)(obj->objsize()) );
   jassert( bb );
-
-  return _getEnv()->CallStaticBooleanMethod( _dbhook , _scopeInit , id , bb );
+
+  int res = _getEnv()->CallStaticBooleanMethod( _dbhook , _scopeInit , id , bb );
+  _getEnv()->DeleteLocalRef( bb );
+  return res;
 }
 
 int JavaJSImpl::scopeSetThis( jlong id , JSObj * obj ){
   if ( ! obj )
     return 0;
-
+  
   jobject bb = _getEnv()->NewDirectByteBuffer( (void*)(obj->objdata()) , (jlong)(obj->objsize()) );
   jassert( bb );
 
-  return _getEnv()->CallStaticBooleanMethod( _dbhook , _scopeSetThis , id , bb );
+  int res = _getEnv()->CallStaticBooleanMethod( _dbhook , _scopeSetThis , id , bb );
+  _getEnv()->DeleteLocalRef( bb );
+  return res;
 }
 
 // scope getters