assert for race condition in checkShardVersion

mongodb · Sep 24, 2010 · bf11872 · bf11872
1 parent 5073890
commit bf11872
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/s/strategy.cpp b/s/strategy.cpp
@@ -192,7 +192,7 @@ namespace mongo {
         static map<string,WriteBackListener*> _cache;
         static mongo::mutex _cacheLock;
 
-        static set<OID> _seenWritebacks;
+        static set<OID> _seenWritebacks; // TODO: this can grow unbounded
         static mongo::mutex _seenWritebacksLock;
 
     public:
@@ -293,6 +293,7 @@ namespace mongo {
         ShardChunkVersion version = 0;
         if ( isSharded ){
             version = manager->getVersion( Shard::make( conn.getServerAddress() ) );
+            assert( officialSequenceNumber == manager->getSequenceNumber() ); // this is to make sure there isn't a race condition
         }
 
         log(2) << " have to set shard version for conn: " << &conn << " ns:" << ns