-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial scons 3.0.1 and python3 build support #1195
Conversation
@bmanojlovic - Thanks for the PR. This has been something I've been hoping to get done for a while. You might be interested also to have a look at https://jira.mongodb.org/browse/SERVER-32295, where another user has also tackled this. I guess the first step would be to compare their and your solutions and come up with a unified proposal? I'm going to ping the submitter of SERVER-32295 and point them to this PR so they can give their thoughts. |
Also, @bmanojlovic - have you signed the MongoDB contributor agreement? |
Yes i have signed it already before pushing PR |
Hm i did not see Marek patch , i will try to create branch with his patch applied to see if he fixed maybe something that i probably missed :) |
My hope is that both of you got 95% of the places, and together it makes 99% :) |
i have already made it build for my usecase (to build it for openSUSE :) ) |
i am trying to make comparison between our "version", here is my try at it |
@bmanojlovic - Did you and Marek ever sync up on this work? I'm still interested in it, but I'd prefer one unified PR. |
scratch that... |
I am combining them into one, will see what on the end it will look like, but i really can't promise 2 and 3 compatibility - will try but can't promise |
@bmanojlovic - Regarding 2 and 3 compat, please see my most recent comment on the SERVER ticket: https://jira.mongodb.org/browse/SERVER-32295?focusedCommentId=1785804&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-1785804 |
acknowledged, will compare with new repository from @omron93 |
Ping? python2 retires in 4 months and 22 days, and several distributions have removed python2, or at least banished it to unofficially supported repositories. |
Python 3 support was added per https://jira.mongodb.org/browse/SERVER-32295, so I'm closing this review. |
@acmorrow Thanks. That link shows it was only added to the unstable 4.1 branch (4.1.10.) So, everyone using the stable 4.0 branch hasn't had this. But, stable was just upgraded from 4.0 to 4.2 which includes python3 support, so this works well enough for me. |
This PR allows building mongo with use of latest (3.0.1) scons which now uses python3 by default.
There are still a lot of rough edges but on the end it allows building binary mongod
python version:
scons version:
and finally running scons on my machine
and of course running built binary