SERVER-3771 -- part 1 (reissue 2) -- don't let 'prompt' become undefined #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a reissue of my earlier fix. I'm trying to break them down into bite-sized parts to make them easier to pull. Test the return value from a call to a function prompt (included regex) and only use it if it is a string. If we have no string prompt, display the default prompt = sayReplSetMemberState()+"> "; . Edited for style.
erh
added a commit
that referenced
this pull request
Nov 1, 2011
SERVER-3771 -- part 1 (reissue 2) -- don't let 'prompt' become undefined
patrickfreed
pushed a commit
that referenced
this pull request
Dec 3, 2018
* Make BulkWriteOptions ordered argument optional This preserves the true default value. * Remove redundant ".json" suffix from CRUD test filenames * Sort BulkWriteResult insertedIds before comparing Swift dictionaries are unordered, while the spec tests assume a particular order. Sort the dictionary before comparison to avoid random test failures. * Make insertMany() consistent with bulkWrite() and test continue-on-error This introduces MongoError.insertManyError, which can include an InsertManyResult and any write/WC errors. The CRUD test harness has been updated to respect the "error" outcome, while still verifying the write result (if available). * Resync CRUD spec write tests Synced with mongodb/specifications@76125be
BradBarnich
pushed a commit
to BradBarnich/mongo
that referenced
this pull request
Feb 6, 2019
…ate-db Add audit::logCreateDatabase event for mmapv1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reissue of my earlier fix. I'm trying to break them down into
bite-sized parts to make them easier to pull.
Test the return value from a call to a function prompt (included regex)
and only use it if it is a string. If we have no string prompt, display
the default prompt = sayReplSetMemberState()+"> "; . Edited for style.