Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-70062: mongocli ops-manager admin backup blockstore(s) lists #470

Merged
merged 7 commits into from
Sep 30, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Sep 30, 2020

Proposed changes

Jira ticket: CLOUDP-70062

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

  ./bin/mongocli om admin backup blockstore list -P ops -o json
{
  "links": [
    {
      "rel": "self",
      "href": "http://localhost:8080/api/public/v1.0/admin/backup/snapshot/mongoConfigs?pageNum=1\u0026itemsPerPage=100"
    }
  ],
  "results": [
    {
      "id": "blockstore",
      "uri": "mongodb://test1:test1@localhost:22222",
      "ssl": false,
      "assignmentEnabled": true,
      "encryptedCredentials": false,
      "loadFactor": 1
    }
  ],
  "totalCount": 1
}

./bin/mongocli om admin backup blockstore list -P ops
ID           URI                                     SSL     LOAD FACTOR
blockstore   mongodb://test1:test1@localhost:22222   false   1

Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one thing that this command namespace is not right, we should have a new admin scope and add it there

internal/cli/opsmanager/backup/backup.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit to drop project from some descriptions as these are global settings

internal/cli/opsmanager/admin/backup/description.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 9bbb84e into master Sep 30, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-70062 branch September 30, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants