Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-70063: mongocli ops-manager admin backup blockstore(s) describe #471

Merged
merged 8 commits into from
Sep 30, 2020

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Sep 30, 2020

Proposed changes

Jira ticket: CLOUDP-70063

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

./bin/mongocli om admin backup blockstore describe blockstore -P ops
ID           URI                                     SSL     LOAD FACTOR
blockstore   mongodb://test1:test1@localhost:22222   false   1
./bin/mongocli om admin backup blockstore describe blockstore -P ops -o json
{
  "id": "blockstore",
  "uri": "mongodb://test1:test1@localhost:22222",
  "ssl": false,
  "assignmentEnabled": true,
  "encryptedCredentials": false,
  "loadFactor": 1
}

@andreaangiolillo
Copy link
Collaborator Author

waiting for #470

Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small copy change as the admin is global and not per project

internal/cli/opsmanager/admin/backup/description.go Outdated Show resolved Hide resolved
internal/cli/opsmanager/admin/description.go Outdated Show resolved Hide resolved
gssbzn
gssbzn previously approved these changes Sep 30, 2020
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM one small comment but not blocking

Comment on lines 17 to 19
short = "Manage backup blockstores."
list = "List backup blockstores."
describe = "Get a backup blockstore."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add the word configuration here, as in, "Manage backup blockstore configuration"

Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaangiolillo andreaangiolillo merged commit 50bfc47 into master Sep 30, 2020
@andreaangiolillo andreaangiolillo deleted the CLOUDP-70063 branch September 30, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants