Fix mongoize update all array operators 8.1 #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cial handling conditions for Mongoize
| @@ -198,7 +198,7 @@ def to_criteria | |||
| def value_for(operator, klass, key, value) | |||
| case operator | |||
| when "$rename" then value.to_s | |||
| when "$addToSet", "$push" then value.mongoize | |||
| when "$addToSet", "$push", '$pull', '$pop' then value.mongoize | |||
There was a problem hiding this comment.
Thanks @johnnyshields. I looked close at this exact question when I was evaluating these PRs, and it's not necessary to specify $pullAll here. In the case of $push, $pull, etc, the value of the operation may different than the declared value of the field itself (because the field is array-valued), and so must be handled specially. For $pullAll, the value is an array, for an array-valued field, and so it is handled fine by the default case.
There was a problem hiding this comment.
@jamis any chances to see this changes in 8.1-stable and next release 8.1.x?
There was a problem hiding this comment.
Thanks for the nudge, @dem. I'm not sure how this fell through the cracks, but I'll get it merged today.
jamis
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding 8.1 fix for https://github.com/mongodb/mongoid/pull/5823/files