Fix mongoize update all array operators master #5823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge $in and $nin when provided as a symbol as well as a string
…$pop in special handling conditions for Mongoize
dem
reviewed
May 20, 2024
| depeche_mode.update_attribute(:genres, ["pop", "electronic", "dance" ]) | ||
| new_order.update_attribute(:genres, ["electronic", "pop", "dance"]) | ||
| context.update_all("$pullAll" => { genres: ["pop", "electronic"] }) | ||
| end |
There was a problem hiding this comment.
@JohnMaguir for $pullAll it is better to prepare multiple entries in the data to be pulled from the array, just to cover it fully:
depeche_mode.update_attribute(:genres, ["pop", "electronic", "dance", "pop" ])
new_order.update_attribute(:genres, ["electronic", "pop", "electronic", "dance"])
There was a problem hiding this comment.
Thank you @dem updated now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue when using
$pullor$popwithupdate_allAtomic operators that deal with arrays or sets:
$addToSet,$push,$pull,$pop,$pullAllOnly
$addToSetand$pushare covered by current tests and$pull,$popfunctionality is broken asMongoid::AtomicUpdatePreparer.mongoize_forreturnsnilfor query such asupdate_all("$pull" => { genres: "electronic" })This became an issue after fixes from #5814 as correct
keyis now being passed toMongoid::AtomicUpdatePreparer.mongoize_forFix is to
mongoizevalue the same way it is for$addToSetor$push.Also added tests for
$pullAlleven though it is currently working but good to have all operators covered.Corresponding fix for 8.1 branch - #5824