Skip to content

Commit

Permalink
test(NODE-4322): update sessions dirty spec tests (#3296)
Browse files Browse the repository at this point in the history
  • Loading branch information
durran committed Jun 23, 2022
1 parent 4a91444 commit cf6d523
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 10 deletions.
6 changes: 1 addition & 5 deletions test/integration/sessions/sessions.spec.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,5 @@ import { loadSpecTests } from '../../spec';
import { runUnifiedSuite } from '../../tools/unified-spec-runner/runner';

describe('Sessions spec tests', function () {
runUnifiedSuite(loadSpecTests('sessions'), [
// TODO(NODE-3951): fix broken dirty sessions spec tests
'Dirty explicit session is discarded (insert)',
'Dirty explicit session is discarded (findAndModify)'
]);
runUnifiedSuite(loadSpecTests('sessions'));
});
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ const SKIPPED_TESTS = [
// TODO(NODE-2034): Will be implemented as part of NODE-2034
'Client side error in command starting transaction',

// TODO(NODE-3951): investigate why this is failing while the legacy version is passing
'Dirty explicit session is discarded',

// TODO(NODE-3308):
'A successful find event with a getmore and the server kills the cursor',

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,6 @@
"name": "insertOne",
"object": "collection0",
"arguments": {
"session": "session0",
"document": {
"_id": 2
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ tests:
- name: insertOne
object: *collection0
arguments:
session: *session0
document: { _id: 2 }
expectResult: { $$unsetOrMatches: { insertedId: { $$unsetOrMatches: 2 } } }
- *find_with_implicit_session
Expand Down

0 comments on commit cf6d523

Please sign in to comment.