Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(NODE-4322): update sessions dirty spec tests #3296

Merged
merged 3 commits into from
Jun 23, 2022
Merged

test(NODE-4322): update sessions dirty spec tests #3296

merged 3 commits into from
Jun 23, 2022

Conversation

durran
Copy link
Member

@durran durran commented Jun 23, 2022

Description

Updates the broken dirty sessions errors spec test.

What is changing?

Spec test sync for sessions, unskip other tests in the sessions suite that happen to be working now

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-4322

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran added the wip label Jun 23, 2022
@durran durran removed the wip label Jun 23, 2022
@durran durran marked this pull request as ready for review June 23, 2022 14:45
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 23, 2022
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 23, 2022
@dariakp dariakp merged commit cf6d523 into main Jun 23, 2022
@dariakp dariakp deleted the NODE-4322 branch June 23, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants