feat(NODE-3419): define MongoRuntimeError children #2893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andymina
changed the title
emadum
suggested changes
Jul 9, 2021
There was a problem hiding this comment.
I think this documentation would read better if we replaced the boilerplate An error generated when an attempt is made to ... to something more succinct like Thrown when attempting to ..., thoughts? Nit, but could we also make the line length used for wrapping consistent across all the docs?
src/error.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * An error generated when teh driver fails to decompress |
There was a problem hiding this comment.
Suggested change
| * An error generated when teh driver fails to decompress | |
| * An error generated when the driver fails to decompress |
src/error.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * An error generated when an attempt to access a resource |
There was a problem hiding this comment.
Suggested change
| * An error generated when an attempt to access a resource | |
| * An error generated when an attempt is made to access a resource |
nbbeeken
changed the base branch from
NODE-3399/Implement-New-Error-hierarchy
to
4.0
nbbeeken
approved these changes
Jul 9, 2021
andymina
force-pushed
the
NODE-3419/define-MongoRuntimeError-children
branch
from
f941c79
to
2ea2e84
Compare
andymina
changed the title
ljhaywar
pushed a commit
that referenced
this pull request
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What changed?
Classes added: