fix(NODE-3795): unexpected No auth provider for DEFAULT defined error #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
previously requested changes
Jan 6, 2022
| @@ -334,5 +334,19 @@ describe('Connection String', function () { | |||
| expect(options).property('credentials').to.equal(credentials); | |||
| expect(options).to.have.nested.property('credentials.source', 'admin'); | |||
| }); | |||
|
|
|||
| it('should retain specified authSource with no provided credentials', async function () { | |||
| makeStub('authSource=thisShouldBeAuthSource'); | |||
There was a problem hiding this comment.
Do we have a similar test for a non-srv connection string?
There was a problem hiding this comment.
just added + added extra assertions on the DEFAULT mechanism to clearly test the specified error scenario in the ticket
nbbeeken
added
the
Primary Review
nbbeeken
reviewed
Jan 7, 2022
nbbeeken
force-pushed
the
NODE-3795/fix-no-authProvider-for-default-error
branch
from
cc0fdd9
to
dbaf782
Compare
dariakp
requested changes
Jan 19, 2022
dariakp
dismissed
nbbeeken’s stale review
Dismissing review since Neal is taking over the implementation
nbbeeken
changed the title
nbbeeken
changed the title
dariakp
requested changes
Jan 19, 2022
There was a problem hiding this comment.
Just a small suggestion because I think the goal of the test, if I understand it, is to make sure that we don't fail in the wrong place, but there's nothing invalid about the setup - we only fail because there isn't a proper server, not because we specified an authSource, right?
dariakp
added
Team Review
Co-authored-by: Daria Pardue <daria.pardue@mongodb.com>
dariakp
previously approved these changes
Jan 19, 2022
durran
requested changes
Jan 20, 2022
test/unit/connection_string.test.ts
Outdated
| @@ -89,6 +94,39 @@ describe('Connection String', function () { | |||
| expect(options.credentials.source).to.equal('$external'); | |||
| }); | |||
|
|
|||
| it('should retain user-specified authSource with no credentials for non-srv URI', function () { | |||
There was a problem hiding this comment.
This test is failing on evg as it expects an empty username but the property does not exist.
…hub.com:mongodb/node-mongodb-native into NODE-3795/fix-no-authProvider-for-default-error
dariakp
requested changes
Jan 20, 2022
dariakp
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding test case and fix for a specified authSource but no further credentials provided.
The spec states that authSource can be ignored when no other credentials are given, we have a check that is throwing in this specific scenario because we still have an empty credentials object making it down to the connection creation layer.
What is changing?
This PR removes the credentials from the options object in this specific scenario and tests for it.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>