Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-4196): add support for showExpandedEvents in change streams #3254

Merged

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented May 18, 2022

Description

What is changing?

This PR adds support for new change stream events guarded behind the showExpandedEvents change stream pipeline stage option. It also adds new fields to some change events when the same flag is enabled.

This PR also contains changes from the following tickets:

Is there new documentation needed for these changes?

No.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson force-pushed the DRIVERS-1975/change-streams-c2c-events branch 2 times, most recently from 6aec144 to a945d02 Compare May 19, 2022 17:17
@baileympearson baileympearson marked this pull request as ready for review May 19, 2022 17:23
@baileympearson baileympearson force-pushed the DRIVERS-1975/change-streams-c2c-events branch 3 times, most recently from 04c8230 to 385e9d4 Compare May 24, 2022 14:24
@bajanam bajanam added the wip label May 24, 2022
@baileympearson baileympearson force-pushed the DRIVERS-1975/change-streams-c2c-events branch from 588c515 to 9764334 Compare May 27, 2022 17:39
@nbbeeken nbbeeken self-requested a review May 27, 2022 20:29
@nbbeeken nbbeeken added Primary Review In Review with primary reviewer, not yet ready for team's eyes and removed wip labels May 27, 2022
*
* @since 6.1.0
*/
collectionUUID: UUID;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a Binary explicit conversion is still the default

@baileympearson baileympearson force-pushed the DRIVERS-1975/change-streams-c2c-events branch from 0601010 to 010be9a Compare June 3, 2022 14:33
src/change_stream.ts Outdated Show resolved Hide resolved
src/change_stream.ts Show resolved Hide resolved
src/change_stream.ts Outdated Show resolved Hide resolved
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 3, 2022
@nbbeeken nbbeeken merged commit 9c1782e into mongodb:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants