feat(NODE-4756)!: ok 1 with write concern failure event changes #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
force-pushed
the
NODE-4756
branch
2 times, most recently
from
040ef39
to
c523c1d
Compare
durran
changed the title
4 tasks
|
Lint failure unrelated to this PR but addressed in #3524 |
durran
force-pushed
the
NODE-4756
branch
3 times, most recently
from
a52b422
to
de23ac1
Compare
durran
commented
Jan 17, 2023
| @@ -500,7 +500,8 @@ function makeOperationHandler( | |||
| ): Callback { | |||
| const session = options?.session; | |||
| return function handleOperationResult(error, result) { | |||
| if (result != null) { | |||
| // We should not swallow an error if it is present. | |||
| if (error == null && result != null) { | |||
There was a problem hiding this comment.
If we are not monitoring commands the operation description's callback doesn't get wrapped and thus both an error and result are present here.
nbbeeken
requested changes
Jan 17, 2023
test/integration/retryable-writes/retryable_writes.spec.prose.test.ts
Outdated
Show resolved
Hide resolved
dariakp
added
the
Primary Review
nbbeeken
requested changes
Jan 18, 2023
test/integration/retryable-writes/retryable_writes.spec.prose.test.ts
Outdated
Show resolved
Hide resolved
nbbeeken
added
Team Review
nbbeeken
requested changes
Jan 19, 2023
Ah that pesky import. |
nbbeeken
previously approved these changes
Jan 19, 2023
dariakp
reviewed
Jan 19, 2023
|
note: red CI is unrelated to changes here, I've filed a ticket about the new failures and we know about the FLE CI script issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For commands with write concern errors but an
{ ok: 1 }in the command reply, the driver now emits a command succeeded event.What is changing?
CommandSucceededEventwhen a reply has{ ok: 1 }with write concern errors.Specs PR: mongodb/specifications#1367
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-4756/DRIVERS-2468
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript