-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-3639): add a general stage to the aggregation pipeline builder #4079
Merged
durran
merged 1 commit into
mongodb:main
from
prenaissance:NODE-3639-general-pipeline-stage
Apr 18, 2024
Merged
feat(NODE-3639): add a general stage to the aggregation pipeline builder #4079
durran
merged 1 commit into
mongodb:main
from
prenaissance:NODE-3639-general-pipeline-stage
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Apr 18, 2024
durran
approved these changes
Apr 18, 2024
durran
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
Apr 18, 2024
nbbeeken
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this contribution!
This was referenced Aug 21, 2024
This was referenced Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
add a general stage method to the aggregation pipeline builder
Is there new documentation needed for these changes?
What is the motivation for this change?
This feature would allow arbitrary aggregation stages to be used builder style with the aggregation cursor, simplifying the syntax needed to use the stages otherwise. Currently only the most common stages have explicit APIs available for chaining and adding an explicit API for every possible aggregation stage would not be maintainable.
This change will also help making progress in other aggregation pipeline typification features, as the aggregation pipeline builder can be used for both stages which have explicit builder helpers and those which do not.
Release Highlight
Aggregation pipelines can now add stages manually.
When creating an aggregation pipeline cursor, a new generic method
addStage()
has been added in the fluid API for users to add stages in a general manner.Thank you @prenaissance for contributing this feature!
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript