Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6165): useBigInt64 causes compareTopologyVersion to throw #4109

Merged
merged 3 commits into from
May 22, 2024

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented May 9, 2024

Description

What is changing?

  • compareTopologyVersion handles bigint inputs
Is there new documentation needed for these changes?

No

What is the motivation for this change?

BSON settings should not make driver internals throw

Release Highlight

Fixed error when useBigInt64=true was set on Db or MongoClient

Fixed an issue where when setting useBigInt64=true on MongoClients or Dbs an internal function compareTopologyVersion would throw an error when encountering a bigint value.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review May 10, 2024 14:36
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 20, 2024
@baileympearson baileympearson merged commit 21b729b into main May 22, 2024
2 of 3 checks passed
@baileympearson baileympearson deleted the NODE-6165-useBigInt-topologyCounter branch May 22, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants