-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-6241): allow Binary as local kms provider key for auto encryption #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Jun 28, 2024
nbbeeken
approved these changes
Jun 28, 2024
nbbeeken
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Jun 28, 2024
This was referenced Oct 3, 2024
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This fixes the compile_ts task in mongosh's CI: https://evergreen.mongodb.com/task/mongosh_linux_unit_compile_ts_667efa29aa31110007944584_24_06_28_18_00_09/0?redirect_spruce_users=true.
Is there new documentation needed for these changes?
What is the motivation for this change?
Release Highlight
The
LocalKMSProviderConfiguration
'skey
property acceptsBinary
for auto encryptionIn #4160 we fixed a type issue where a
local
KMS provider at runtime accepted aBSON
Binary
instance but the Typescript inaccurately only permittedBuffer
andstring
. The same change has now been applied toAutoEncryptionOptions
.Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript