Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove required value property #51

Merged
merged 1 commit into from
May 13, 2019
Merged

Fix: Remove required value property #51

merged 1 commit into from
May 13, 2019

Conversation

sophstad
Copy link
Member

The Class role (updated in DOCSP-5425) does not require a label.value property, which was previously marked as required and lead to page render failure. If label.value is not specified, use the role's target property as the link text.

@danielborowski
Copy link
Contributor

LGTM

@sophstad sophstad merged commit d4321bb into master May 13, 2019
@sophstad sophstad deleted the fix-role branch May 13, 2019 20:28
graysonhicks pushed a commit that referenced this pull request Jan 20, 2023
@sophstad
Fix: failure caused by missing value property (#51)
4184b28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielborowski danielborowski Awaiting requested review from danielborowski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sophstad @danielborowski