Fix: failure caused by missing value property (#51)

mongodb · May 13, 2019 · 4184b28 · 4184b28
1 parent d8447ef
commit 4184b28
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 15 deletions.
diff --git a/src/components/Roles/Class.js b/src/components/Roles/Class.js
@@ -2,24 +2,22 @@ import React from 'react';
 import PropTypes from 'prop-types';
 
 const baseUrl = 'https://api.mongodb.com/python/current/api/pymongo/results.html#';
-const RoleClass = ({
-  nodeData: {
-    label: { value },
-    target,
-  },
-}) => (
-  <a href={`${baseUrl}${target}`} className="reference external">
-    <code className="xref py py-class docutils literal notranslate">
-      <span className="pre">{value}</span>
-    </code>
-  </a>
-);
+const RoleClass = ({ nodeData: { label, target } }) => {
+  const labelDisplay = label && label.value ? label.value : target;
+  return (
+    <a href={`${baseUrl}${target}`} className="reference external">
+      <code className="xref py py-class docutils literal notranslate">
+        <span className="pre">{labelDisplay}</span>
+      </code>
+    </a>
+  );
+};
 
 RoleClass.propTypes = {
   nodeData: PropTypes.shape({
     label: PropTypes.shape({
-      value: PropTypes.string.isRequired,
-    }).isRequired,
+      value: PropTypes.string,
+    }),
     target: PropTypes.string.isRequired,
   }).isRequired,
 };

diff --git a/src/components/Roles/Doc.js b/src/components/Roles/Doc.js
@@ -19,7 +19,7 @@ const RoleDoc = ({ nodeData: { label, target }, refDocMapping }) => {
 RoleDoc.propTypes = {
   nodeData: PropTypes.shape({
     label: PropTypes.shape({
-      value: PropTypes.string.isRequired,
+      value: PropTypes.string,
     }),
     target: PropTypes.string.isRequired,
   }).isRequired,