Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra indirection in BSON.array(_:)? #87

Open
tayloraswift opened this issue Oct 20, 2022 · 2 comments
Open

extra indirection in BSON.array(_:)? #87

tayloraswift opened this issue Oct 20, 2022 · 2 comments

Comments

@tayloraswift
Copy link
Contributor

tayloraswift commented Oct 20, 2022 •
edited
Loading

not sure why the BSON.array(_:) enum case is marked indirect, because [BSON] is already indirectly stored?

(not a bug, the label was added automatically and i cannot remove it)
@tayloraswift tayloraswift added the bug Something isn't working label Oct 20, 2022
@kmahar
Copy link
Contributor

kmahar commented Oct 25, 2022

Huh, I'm not sure why this is marked indirect. it doesn't seem necessary to make the code compile on any Swift version we support and was likely a mistake. that said, would removing indirect possibly be a breaking change?

@tayloraswift
Copy link
Contributor Author

it would not be source-breaking, but it could possibly be ABI breaking. a quick google search didn’t yield anything, so we should probably ask a compiler dev

@bajanam bajanam removed bug Something isn't working triage labels Nov 1, 2022
@kmahar kmahar removed their assignment Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tayloraswift @kmahar @bajanam