Skip to content

Commit

Permalink
Merge pull request #66 from dblock/contributing
Browse files Browse the repository at this point in the history
Added CONTRIBUTING.
  • Loading branch information
dblock committed Nov 22, 2016
2 parents d0947de + 1ce2139 commit d9d686c
Show file tree
Hide file tree
Showing 2 changed files with 119 additions and 4 deletions.
118 changes: 118 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,118 @@
Contributing to Mongoid::GridFs
===============================

Mongoid::GridFs is work of [many of contributors](https://github.com/mongoid/mongoid-grid_fs/graphs/contributors). You're encouraged to submit [pull requests](https://github.com/mongoid/mongoid-grid_fs/pulls), [propose features, ask questions and discuss issues](https://github.com/mongoid/mongoid-grid_fs/issues).

#### Fork the Project

Fork the [project on Github](https://github.com/mongoid/mongoid-grid_fs) and check out your copy.

```
git clone https://github.com/contributor/mongoid-grid_fs.git
cd mongoid-grid_fs
git remote add upstream https://github.com/mongoid/mongoid-grid_fs.git
```

#### Create a Topic Branch

Make sure your fork is up-to-date and create a topic branch for your feature or bug fix.

```
git checkout master
git pull upstream master
git checkout -b my-feature-branch
```

#### Bundle Install and Test

Ensure that you can build the project and run tests.

```
bundle install
bundle exec rake
```

#### Write Tests

Try to write a test that reproduces the problem you're trying to fix or describes a feature that you want to build. Add to [test](test).

We definitely appreciate pull requests that highlight or reproduce a problem, even without a fix.

#### Write Code

Implement your feature or bug fix.

Ruby style is enforced with [Rubocop](https://github.com/bbatsov/rubocop), run `bundle exec rubocop` and fix any style issues highlighted.

Make sure that `bundle exec rake` completes without errors.

#### Write Documentation

Document any external behavior in the [README](README.md).

#### Update Changelog

Add a line to [CHANGELOG](CHANGELOG.md) under *Next Release*. Make it look like every other line, including your name and link to your Github account.

#### Commit Changes

Make sure git knows your name and email address:

```
git config --global user.name "Your Name"
git config --global user.email "contributor@example.com"
```

Writing good commit logs is important. A commit log should describe what changed and why.

```
git add ...
git commit
```

#### Push

```
git push origin my-feature-branch
```

#### Make a Pull Request

Go to https://github.com/contributor/mongoid-grid_fs and select your feature branch. Click the 'Pull Request' button and fill out the form. Pull requests are usually reviewed within a few days.

#### Rebase

If you've been working on a change for a while, rebase with upstream/master.

```
git fetch upstream
git rebase upstream/master
git push origin my-feature-branch -f
```

#### Update CHANGELOG Again

Update the [CHANGELOG](CHANGELOG.md) with the pull request number. A typical entry looks as follows.

```
* [#123](https://github.com/mongoid/mongoid-grid_fs/pull/123): Reticulated splines - [@contributor](https://github.com/contributor).
```

Amend your previous commit and force push the changes.

```
git commit --amend
git push origin my-feature-branch -f
```

#### Check on Your Pull Request

Go back to your pull request after a few minutes and see whether it passed muster with Travis-CI. Everything should look green, otherwise fix issues and amend your commit as described above.

#### Be Patient

It's likely that your change will not be merged and that the nitpicky maintainers will ask you to do more, or fix seemingly benign problems. Hang on there!

#### Thank You

Please do know that we really appreciate and value your time and work. We love you, really.
5 changes: 1 addition & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,7 @@ It has the following features:
CONTRIBUTING
------------

```
$ bundle install
$ bundle exec rake test
```
See [CONTRIBUTING](CONTRIBUTING.md).

LICENSE
-------
Expand Down

0 comments on commit d9d686c

Please sign in to comment.