Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Trackable::association_hash to write through parent. #34

Merged
merged 2 commits into from May 1, 2012

Commits on Apr 30, 2012

  1. Updating Trackable::association_hash to write through parent.

    Currently there are cases (on destroy mianly) where an child document
    would write it's class name to the association_hash 'name' field. This
    happens  when it fails to lookup the relationship meta information pertaining to it's
    parent OR when the child has been deleted off the parent record before
    the destroy history track has been written.
    
    Then if you are trying to use that history track later on, it would fail
    the to be able to lookup it's trackable_parent, among other methods,
    because it would try to traverse a relationship titled "Comment"
    instead of the actual name of teh association, 'comments'.
    
    This fix makes it so a child document doesn't fail to lookup the name of
    the relation, when a parent is present, regardless of when the delete
    occurs.
    Tyler Copple committed Apr 30, 2012
    Configuration menu
    Copy the full SHA
    c38dcd7 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2012

  1. Cleaning up typos in comments and spacing.

    Tyler Copple committed May 1, 2012
    Configuration menu
    Copy the full SHA
    fc44e25 View commit details
    Browse the repository at this point in the history