Ensure that index matches scope [Fixes #33] #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, +1. I think this needs a CHANGELOG line, too. |
joeyAghion
force-pushed
the
scoped_index
branch
from
efecbb9
to
d9eafb4
Compare
|
Amended with a CHANGELOG line. |
pyromaniac
added a commit
that referenced
this pull request
Oct 4, 2014
Ensure that index matches scope [Fixes #33]
|
That is awesome, thanks. And I completely forgot about the changelog :) Have to review and renew it. |
|
@pyromaniac Could you cut a release with this? This gem isn't going to see too many updates ... |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prefixes the declared index with the scope (if defined), fixing #33.
Note that scopes defined as lambdas can't be easily indexed this way, so I chose to leave the default behavior (of indexing only
position) in that case. In many cases, it may actually be preferable to disable the automatic index and declare another manually.