This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
fix retries operations #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2015
wandenberg
force-pushed
the
fix_retries_operations
branch
from
4926c2c
to
0205bcc
Compare
|
Finally!! 😃 |
| Loggable.warn(" MOPED:", "Retrying connection attempt #{retries} more time(s).", "n/a") | ||
| sleep(cluster.retry_interval) | ||
| cluster.refresh | ||
| with_retry(cluster, retries - 1, &block) |
There was a problem hiding this comment.
why not use
retries -= 1
retry
here instead of recursion? Recursion is just going to add to the heap, whereas using retry should be a lot more lightweight.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same pull request as #328, just rebased (I'll close the old one)
The pull request #324 does not deal with write operations after a replicaset reconfiguration.
And the tests with replicaset simulator does not represent the real world where the election of a new primary can take some seconds.
I moved some of the code I did on pull request #315 to this one based on tag 2.0.1.
I hope you can check and merge it on master.
The tests are done with a real replicaset using the stepDown command.