Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify supported Docker versions #46

Closed
marcusianlevine opened this issue May 2, 2018 · 4 comments
Closed

Clarify supported Docker versions #46

marcusianlevine opened this issue May 2, 2018 · 4 comments
Assignees

Comments

@marcusianlevine
Copy link
Collaborator

marcusianlevine commented May 2, 2018

I tried to run my existing playbooks with the latest version and got an error when trying to install with docker_version: 17.06 on Ubuntu 16.04 because the specified version is not available from the configured apt repo.

So it seems we no longer support all of the versions of the Docker engine we used to with the old 0.1.0 Rancher scripts.

The new logic relies on the yum/apt repositories at https://download.docker.com/linux/ but these repos seem to only support edge, nightly, test and stable tags — not individual Docker versions.

For now I just pinned down to 0.1.0, but we should clarify in the README which versions of Docker can be installed with this role, and ideally provide options for people to install older versions of the Docker engine, maybe just falling back to the Rancher scripts if need be...

@paulfantom
Copy link
Collaborator

paulfantom commented May 2, 2018

Those repos have previous docker versions in them, so there is no need of reverting to rancher script. For example full version of docker 17.06 on ubuntu 16.04 is 17.06.0~ce-0~ubuntu.

I think that there is a problem how docker_package variable is created and that's why setting docker_version: 17.06 failed on ubuntu. Probably setting docker_version: 17.06.0~ce-0~ubuntu would temporarily solve this, could you test it?

@mongrelion
Copy link
Owner

Is it possible to reproduce this issue in our current test suite? If so, I'd like to see it attached to whatever proposal for a fix to make sure that it is truly fixed.

@paulfantom
Copy link
Collaborator

paulfantom commented May 7, 2018

We would need another test scenario, and molecule 1.x doesn't support multiple scenarios. Right now it's either latest or some specified version.

@paulfantom
Copy link
Collaborator

@mongrelion I did a migration to molecule 2.x in #49, after merging it I can rebase #47 and add there another scenario with more tests including one with pinned docker version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants